Fix: CMake variables and segfault on vdecmd #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielinux
approved these changes
Dec 25, 2024
Member
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the CMake porting (674c8ec) the
vdecmdwas broken. The problem was that for CMake the variablesCMAKE_INSTALL_SYSCONFDIRandCMAKE_INSTALL_LOCALSTATEDIRdo not start with a/: https://cmake.org/cmake/help/latest/command/install.html.I added the
/.I have also added the empty element at the end of the array of the options for getopt in order to avoid segfaults on invalid arguments. From the docs of getopt: