Skip to content

Conversation

@gianlourbano
Copy link
Contributor

Conversion of the build system from automake to cmake.

@danielinux
Copy link
Member

Thanks @gianlourbano - please fix the automated tests to replace the build step accordingly (see failed actions).

@danielinux
Copy link
Member

Sorry I did not realize this was blocked because the tests did not run. There seems to be still a cmake-related failure on MacOS.

@gianlourbano
Copy link
Contributor Author

yes, just updated the ci file, i think it should work now

@danielinux
Copy link
Member

Still no luck. There's always some trial and error involved with github actions 😁

@gianlourbano
Copy link
Contributor Author

don't worry, i think i know where the problem is. I'll try on my macbook first

@danielinux
Copy link
Member

MacOS test passes now

@gianlourbano
Copy link
Contributor Author

Everything should work now. Incredible skill issue on my part, sorry

@danielinux danielinux self-requested a review December 3, 2024 15:42
@danielinux
Copy link
Member

🥳 everything works now! Thanks @gianlourbano !

Can you please squash into a single commit, there's a lot of fixups in this tree.

@gianlourbano
Copy link
Contributor Author

I think there is a "squash and merge" option when merging, might have to click "try the new merging experience"

@danielinux
Copy link
Member

I'd rather do it manually, I'm not sure what the web tool is doing under the hood. I'll take care of this step. I'll merge this ASAP. Thank you!

@danielinux danielinux merged commit 674c8ec into virtualsquare:master Dec 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants