Open
Conversation
violatingcp
pushed a commit
that referenced
this pull request
Feb 1, 2021
Support reading HLSConfig from yml files in tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for letting me work on this, I learned a lot!
The implementation passes csim with 0 errors now, and I was able to synthesize my test model too. This will probably need some validation, but I guess we can merge so that more people will have chances to validate this.
I'm working on this during my free time, so I won't be able to help too much. But I'll likely contribute to the pytorch conversion stuffs too, since it's still quite limited.