Added the feature that get input through flags#179
Open
lazy8055 wants to merge 3 commits intovinitshahdeo:feature/python3.8from
Open
Added the feature that get input through flags#179lazy8055 wants to merge 3 commits intovinitshahdeo:feature/python3.8from
lazy8055 wants to merge 3 commits intovinitshahdeo:feature/python3.8from
Conversation
|
Thanks for opening this pull request! 🤗 Check out few other repos below 🚀 PS: Please add @vinitshahdeo / @Kashish121 / @ishika1727 as a reviewer if you haven't added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In feature/python3.8 branch, ipscanner.py in src folder is modified
Instead of getting the input from user and access the config.json file for inputs, getting the input from the user through flags is easy.So i add a feature that get the inputs through flags if any flag is not used , it get the input in the formal way.
For the user, it easy to use flags than each time changing the config.json file
Here, the range is from 0 to 255, number of thread is 8 and the ip address is 194.165.43.2
Here the '-i' flag is not used , so it get input from the user in the formal way
Flags: