Skip to content

Updated scanner.py --> Config.json was wrongly pathed#178

Open
rexj8 wants to merge 1 commit intovinitshahdeo:masterfrom
rexj8:master
Open

Updated scanner.py --> Config.json was wrongly pathed#178
rexj8 wants to merge 1 commit intovinitshahdeo:masterfrom
rexj8:master

Conversation

@rexj8
Copy link
Copy Markdown

@rexj8 rexj8 commented Oct 1, 2021

Description

There is a bug in file src/scanner.py line 41 --> print get_absolute_path('../config.json')

  • get_absolute_path function searching the config.json file in src dir but it is present in root dir.

Fixes # (issue)

Type of change

  • Bug fix (The path of config.json is wrong in src/scanner.py in line 41)

@welcome
Copy link
Copy Markdown

welcome bot commented Oct 1, 2021

Thanks for opening this pull request! 🤗
Are you looking for more beginner-friendly issues? Check out this repo.

Hacktoberfest2020

Open Source Love

Check out few other repos below 🚀

inspirational-quotes
SimpleBio
HBD
Map Of India

PS: Please add @vinitshahdeo / @Kashish121 / @ishika1727 as a reviewer if you haven't added.

@Kashish121
Copy link
Copy Markdown
Collaborator

@rexj8 consider creating the PR in develop branch and not in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants