Skip to content

requirement.txt added#153

Open
palrohitg wants to merge 4 commits intovinitshahdeo:feature/python3.8from
palrohitg:feature/python3.8
Open

requirement.txt added#153
palrohitg wants to merge 4 commits intovinitshahdeo:feature/python3.8from
palrohitg:feature/python3.8

Conversation

@palrohitg
Copy link
Copy Markdown

Description

Making a requirements.txt to install all dependencies #148
added the requirement.txt for branch features/python3.8

Fixes # (148)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules
  • I have added all the three reviewers: @vinitshahdeo, @Kashish121 & @ishika1727

@welcome
Copy link
Copy Markdown

welcome bot commented Mar 13, 2021

Thanks for opening this pull request! 🤗
Are you looking for more beginner-friendly issues? Check out this repo.

Hacktoberfest2020

Open Source Love

Check out few other repos below 🚀

inspirational-quotes
SimpleBio
HBD
Map Of India

PS: Please add @vinitshahdeo / @Kashish121 / @ishika1727 as a reviewer if you haven't added.

Copy link
Copy Markdown
Owner

@vinitshahdeo vinitshahdeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kashish121 Can you please verify the dependencies mentioned in requirement.txt?

@vinitshahdeo vinitshahdeo added gssoc21 Level2 Minor Feature or Bug Fix labels Mar 13, 2021
itsdangerous==1.1.0
Jinja2==2.11.3
MarkupSafe==1.1.1
Werkzeug==1.0.1
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the following requirements also:
Python >= v2.7.0 || v3.7.0
Node.js >= v0.10.0
Pip >= v9.0.1

Python packages: flask

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kashish121 could you tell me why this is required as pip and python is the outside dependencies means firstly then user will activate the virutalenv and then hit the python commands. @vinitshahdeo Let me know you thought also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc21 Level2 Minor Feature or Bug Fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants