Skip to content

Added Contributor#145

Open
rohan-kulkarni-25 wants to merge 3 commits intovinitshahdeo:masterfrom
rohan-kulkarni-25:Contributor
Open

Added Contributor#145
rohan-kulkarni-25 wants to merge 3 commits intovinitshahdeo:masterfrom
rohan-kulkarni-25:Contributor

Conversation

@rohan-kulkarni-25
Copy link
Copy Markdown

@rohan-kulkarni-25 rohan-kulkarni-25 commented Mar 13, 2021

Description

Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

I have added the contributor section

Fixes #140
reviewers: @vinitshahdeo , @Kashish121 & @ishika1727

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • [] Any dependent changes have been merged and published in downstream modules
  • I have added all the three reviewers: @vinitshahdeo, @Kashish121 & @ishika1727

@welcome
Copy link
Copy Markdown

welcome bot commented Mar 13, 2021

Thanks for opening this pull request! 🤗
Are you looking for more beginner-friendly issues? Check out this repo.

Hacktoberfest2020

Open Source Love

Check out few other repos below 🚀

inspirational-quotes
SimpleBio
HBD
Map Of India

PS: Please add @vinitshahdeo / @Kashish121 / @ishika1727 as a reviewer if you haven't added.

Copy link
Copy Markdown
Collaborator

@Kashish121 Kashish121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @rohank2502 , just one thing, can you change "Contributors:" to "Other contributors:" or "Credits:" ? That ways we can avoid having 2 headings with same title.

image

@rohan-kulkarni-25
Copy link
Copy Markdown
Author

Done @Kashish121

README.md Outdated

### Credits goes to these people:✨

<table>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this to the existing Contributors section.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please @vinitshahdeo Tell me exaclty what to Do I don't get it !!

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohank2502,
You can remove ## Other contributors: and move this section - ### Credits goes to these people:✨ to line 249, that is, just above the Admin section.

@vinitshahdeo
Copy link
Copy Markdown
Owner

@Kashish121 The sourcerer Hall Of fame is deprecated now, so moving this contributor's grid to primary contributors section will be great.

Copy link
Copy Markdown
Collaborator

@Kashish121 Kashish121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the changes by today EOD.

@rohan-kulkarni-25
Copy link
Copy Markdown
Author

I have don the changes please have a look @Kashish121 @vinitshahdeo
88888

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding Contributor section in readme ( Automatically )

3 participants