Skip to content

Checks should rely on whether the grid has been initialized #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tnagler merged 1 commit into from
Aug 18, 2025
Merged

Checks should rely on whether the grid has been initialized #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/kde1d/kde1d.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,15 +814,15 @@ Kde1d::check_xmin_xmax(const double& xmin, const double& xmax) const
inline void
Kde1d::check_fitted() const
{
if (std::isnan(loglik_)) {
if (grid_.get_grid_points().size() == 0) {
throw std::runtime_error("You must first fit the KDE to data.");
}
}

inline void
Kde1d::check_notfitted() const
{
if (!std::isnan(loglik_)) {
if (grid_.get_grid_points().size() > 0) {
throw std::runtime_error(
"This method can't be used for already fitted objects.");
}
Expand Down
Loading