Skip to content

First step to make config compatible with awesome 3.5#5

Open
P-EB wants to merge 11 commits intovincentbernat:masterfrom
P-EB:master
Open

First step to make config compatible with awesome 3.5#5
P-EB wants to merge 11 commits intovincentbernat:masterfrom
P-EB:master

Conversation

@P-EB
Copy link
Copy Markdown

@P-EB P-EB commented Jul 30, 2015

Hey,

I tried to adapt your awesome configuration to awesome 3.5.

I unfortunately have to enlight some differences :

  • First, the automatic deletion of the last tag when its last client is killed does not happen, this is the consequence of the new way I have to use to delete a tag (it seems that awful.tag.delete does not delete a tag when it's the last one)
  • I removed the icons handling in rules. This, I admit, is because I did not find a proper replacement for the global image function/class, and since I do not use these icons, I decided that it was not that important in a first shot.
  • I added a thermal widget and a RAM widget.
  • I modified the battery widget, I suppose you'll want to get yours back. :)
  • I added a basic wallpaper in theme.lua, it would require desktop-base under debian to work.
  • I customized awesome.quit to allow it handling proper quit from both awesome (standalone) and gnome wrapper.

I think it is possible that I've done some other small modifications. Maybe on purpose, maybe not.

I tried to keep all your stuff and adapt as far as possible to awesome 3.5 without modifying the behaviour of your config.

About shifty.lua, I made a lot of fixes in it, but I realized that somebody else already done them : have a look at https://github.com/cdump/awesome-shifty .

Hope I didn't messed up with anything else.

Please, if you have time, try to review, and give me feedback. I'll be happy to try fixing my mistakes and make your config work under awesome 3.5.

Cheers!

@P-EB
Copy link
Copy Markdown
Author

P-EB commented Jan 5, 2016

Hey, I had the possibility to test multiple screens today.

That allowed me to find some bugs.

Commits 2dd9cdc and 06af231 are fixes.

I also merged your commits from july 24th to the one before your last one.

@P-EB
Copy link
Copy Markdown
Author

P-EB commented Mar 23, 2016

There is a bunch of commits since I merged your changes and patched some bugs my upgrade to 3.5 introduced.

@vincentbernat
Copy link
Copy Markdown
Owner

❦ 22 mars 2016 21:30 -0700, Pierre-Elliott Bécue notifications@github.com :

There is a bunch of commits since I merged your changes and patched
some bugs my upgrade to 3.5 introduced.

Thanks! On my side, still no time to do a migration. :-/

Write clearly - don't sacrifice clarity for "efficiency".
- The Elements of Programming Style (Kernighan & Plauger)

@P-EB
Copy link
Copy Markdown
Author

P-EB commented Mar 24, 2016

Le mardi 22 mars 2016 à 23:42:30-0700, Vincent Bernat a écrit :

❦ 22 mars 2016 21:30 -0700, Pierre-Elliott Bécue notifications@github.com :

There is a bunch of commits since I merged your changes and patched
some bugs my upgrade to 3.5 introduced.

Thanks! On my side, still no time to do a migration. :-/

No worries, there is no emergency, I'll continue to clean up my config and
add fixes as soon as it's useful.

Cheers,

PEB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants