Chore/build for all #16
Conversation
- Add internal buildType (debug-signed) and dist export task - Add release APK export task and validateReleaseSigning alias - Document Android build tasks in README - Add .github/copilot-instructions.md for agent guidance
There was a problem hiding this comment.
Pull request overview
This pull request adds build infrastructure and improves the development setup for the Blanket for Android project. It introduces Docker support, custom Gradle build tasks for generating distributable APKs, and updates Material icons to use the extended icon set.
Key changes:
- Added custom Gradle tasks for building debug, release, and internal APK variants with stable output filenames
- Introduced a new "internal" build variant for local testing without requiring a private keystore
- Added Docker compose files and Dockerfile (though the Dockerfile appears to be placeholder content)
- Updated Material Design icons from basic to extended versions (Coffee → LocalCafe, Waving → WavingHand)
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| compose.yaml | Adds Docker Compose configuration for the blanketforandroid service |
| compose.debug.yaml | Adds debug variant of Docker Compose configuration |
| Dockerfile | Adds a Dockerfile with Alpine/fortune placeholder content (appears incomplete for Android builds) |
| .dockerignore | Adds Docker ignore rules for build artifacts and development files |
| app/build.gradle.kts | Adds "internal" build variant, custom APK build tasks, material-icons-extended dependency, and validateReleaseSigning compatibility task |
| app/src/main/java/com/vinberg88/blanketforandroid/model/Sound.kt | Updates icons to use material-icons-extended variants (LocalCafe, WavingHand) |
| app/src/main/java/com/vinberg88/blanketforandroid/audio/AudioPlayer.kt | Refactors loadSound function structure with adjusted indentation and explicit Unit return |
| README.md | Adds comprehensive Android build documentation with command-line instructions for all build variants |
| .github/copilot-instructions.md | Adds GitHub Copilot configuration with project architecture details and conventions |
| .vscode/settings.json | Adds VS Code Java configuration setting |
|
|
||
| Unit |
There was a problem hiding this comment.
The explicit Unit return on line 33 is unnecessary in Kotlin. Since withContext already returns Unit when the lambda doesn't explicitly return a value, and the function signature doesn't specify a return type, this explicit Unit serves no purpose and should be removed for cleaner code.
| Unit |
|
|
||
|
|
||
| ## Description | ||
| IF you use LINUX look here. |
There was a problem hiding this comment.
The word "IF" should be lowercase "If" at the beginning of the sentence.
| IF you use LINUX look here. | |
| If you use LINUX look here. |
| FROM alpine:latest | ||
| LABEL Name=blanketforandroid Version=0.0.1 | ||
| RUN apk add --no-cache fortune | ||
| ENTRYPOINT ["sh", "-c", "fortune -a | cat"] |
There was a problem hiding this comment.
The Dockerfile appears to be a placeholder or test file that runs the fortune command in Alpine Linux. This doesn't align with the Android application context of this repository. If Docker support is intended for building or running the Android app, the Dockerfile should contain appropriate Android build tools and commands. If this is intentionally a placeholder for future implementation, consider adding a comment explaining this.
No description provided.