Feat: make henkanFirst available for use in the keymap #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shougo
reviewed
Aug 17, 2025
|
|
||
| if (context.state.mode === "direct") { | ||
| context.kakutei(key); | ||
| // To prevent the infinite recursive call when henkanFirst itself is registered in rom_kana table. |
Contributor
|
手元にて動作することを確認。 |
Member
|
PRありがとうございます。ただ、すみませんがhenkanFirstにkanaInputの中身をコピーするという書き方は今後のメンテナンスのことを考えると受け入れられません。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#183 に関連
変換キーを keymap に移動しました。また、
henkanPointが設定されていない場合、henkanFirstがkanaInputを呼び出すように変更しました。動作例
上部に記載されているのはvimrcの設定例です。