📦 Upgrade @denops/core to v8 #38

lambdalisue · 2025-09-28T17:51:18Z

🎯 Purpose

This PR upgrades the @denops/core dependency from v7 to v8 to ensure compatibility with the latest denops ecosystem.

📝 Description

What Changed

Upgraded all @denops/core imports from ^7.0.0 to ^8.0.0
Updated 7 TypeScript files that import @denops/core
No code changes required beyond version bumps

Implementation Approach

Simple version bump across all import statements - the v8 API maintains backward compatibility.

🔄 Type of Change

🐛 Bug fix (non-breaking change fixing an issue)
✨ New feature (non-breaking change adding functionality)
💥 Breaking change (fix or feature causing existing functionality to change)
🔧 Refactor (code change that neither fixes a bug nor adds a feature)
📝 Documentation (documentation changes only)
🚀 Performance (performance improvements)
✅ Test (test additions or corrections)
📦 Dependencies (dependency version updates)

🧪 Testing

Test Coverage

Unit tests pass without modification
Type checking passes
All 59 tests pass (29 steps)

Test Results

✅ 59 tests passed (29 steps)
❌ 0 tests failed
⏱️  Execution time: ~3 seconds

✅ Checklist

Code Quality

My code follows the project's style guidelines
I have performed a self-review of my own code
My changes generate no new warnings (type checking passes)

Documentation

No documentation changes needed (pure dependency update)

Testing

New and existing unit tests pass locally
Test coverage remains the same

Dependencies

Updated @denops/core from v7 to v8
No additional dependencies added
Maintains API compatibility

🔗 Related Issues

No related issues - proactive dependency update to stay current with denops ecosystem.

🚀 Deployment Notes

Database migrations required: No
Environment variables added: No
Breaking changes: No
This is a non-breaking dependency update

📊 Performance Impact

No performance impact expected - version update only.

📚 References

denops/core repository
This update ensures compatibility with other denops plugins using v8

Reviewer Tips:

All changes are in import statements only
Focus on ensuring no imports were missed
The inline imports with version specifiers are intentional (see README.md line 189)

Summary by CodeRabbit

Chores
- Bumped core dependency and upgraded CI/runtime tooling to new major versions for compatibility; removed scheduled dependency-update workflow and obsolete publish job; added lint configuration and cleaned project config (removed legacy keys and tasks).
Tests
- Updated type references in tests and helpers to align with new dependency typings; no behavioral changes.
Documentation
- Updated README badges and CI notes to reflect newer Deno, Vim, and Neovim versions.

coderabbitai · 2025-09-28T17:51:25Z

Walkthrough

Bumps Denops core imports from jsr:@denops/core@^7.0.0 → jsr:@denops/core@^8.0.0 across source and tests; updates GitHub Actions (Deno/action versions and matrices), README badges, removes the scheduled update workflow, and edits deno.jsonc (removes version/tasks, adds lint rules). No runtime control-flow or public API changes.

Changes

Cohort / File(s)	Summary of changes
Core source imports `denops.ts`, `plugin.ts`, `stub.ts`, `tester.ts`, `with.ts`	Updated Denops type/import specifier from `jsr:@denops/core@^7.0.0` → `jsr:@denops/core@^8.0.0`; no logic or API changes.
Tests `stub_test.ts`, `with_test.ts`	Updated Denops type import version to `jsr:@denops/core@^8.0.0`; test logic unchanged.
Workflows `.github/workflows/jsr.yml`, `.github/workflows/test.yml`, (removed) `.github/workflows/update.yml`	Bumped Deno versions/matrices to 2.x, upgraded `denoland/setup-deno` v1 → v2, updated publish action versions, altered test/coverage commands and host matrices; removed scheduled `update.yml`.
Documentation / Badges `README.md`	Updated Deno, Vim/Neovim badges and workflow references (setup-deno v2); added Deno 2.3 exclude note.
Config `deno.jsonc`	Removed top-level `version` and `exclude`, removed tasks `test:coverage`, `coverage`, `update`, `update:commit`; added `lint.rules.exclude: ["no-import-prefix"]`; minor structural edits.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Upgrade dependencies and improve README #19 — Coordinated Denops core dependency version bumps across the same source and test files.
☕ Migrate Update workflow to molt-action #33 — Related changes to the repository's automated update workflow (overlaps removal/replacement of .github/workflows/update.yml).
Update deno.jsonc #35 — Modifies update-related tasks/commands similar to removed deno.jsonc update tasks.

Poem

I hop through lines and nudge a key,
Eight dons Denops, light and free.
Workflows shift and badges gleam,
Config trimmed to tighter seam.
Thump — a rabbit's tiny beam 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title Check	⚠️ Warning	The title clearly identifies the main change as upgrading @denops/core to version 8 but includes an unnecessary emoji prefix, which adds noise and does not follow the guideline to avoid emojis in concise titles.	Please remove the emoji prefix and use a concise title such as “Upgrade @denops/core to v8” to clearly convey the change without extraneous characters.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch v8

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 083b23a and 23146b3.

📒 Files selected for processing (3)

.github/workflows/test.yml (3 hunks)
.github/workflows/update.yml (0 hunks)
deno.jsonc (1 hunks)

💤 Files with no reviewable changes (1)

.github/workflows/update.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2025-09-28T17:57:05Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.34%. Comparing base (84599aa) to head (23146b3).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   93.59%   93.34%   -0.25%     
==========================================
  Files           7        7              
  Lines         484      451      -33     
  Branches       55       54       -1     
==========================================
- Hits          453      421      -32     
+ Misses         31       30       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Shougo · 2025-09-29T05:06:35Z


0s
Run deno task coverage --lcov > coverage.lcov
  deno task coverage --lcov > coverage.lcov
  shell: C:\Program Files\Git\bin\bash.EXE --noprofile --norc -eo pipefail {0}
  env:
    DENOPS_BRANCH: main
    DENOPS_TEST_VERBOSE: 
    DENOPS_TEST_DENOPS_PATH: /tmp/denops.vim
    DENOPS_TEST_VIM_EXECUTABLE: C:\Users\runneradmin\vim-v9.1.1646\vim.exe
    DENOPS_TEST_NVIM_EXECUTABLE: C:\Users\runneradmin\nvim-v0.11.3\bin\nvim.exe
Task coverage deno coverage .coverage "--lcov"
error: Failed reading 'D:\a\deno-denops-test\deno-denops-test\.coverage\029bbb54-fcc6-42c0-8205-9a28961d8a65.json'
Caused by:
    EOF while parsing a value at line 1 column 0
Error: Process completed with exit code 1.
Run deno task coverage --lcov > coverage.lcov
  deno task coverage --lcov > coverage.lcov
  shell: C:\Program Files\Git\bin\bash.EXE --noprofile --norc -eo pipefail {0}
  env:
    DENOPS_BRANCH: main
    DENOPS_TEST_VERBOSE: 
    DENOPS_TEST_DENOPS_PATH: /tmp/denops.vim
    DENOPS_TEST_VIM_EXECUTABLE: C:\Users\runneradmin\vim-v9.1.1646\vim.exe
    DENOPS_TEST_NVIM_EXECUTABLE: C:\Users\runneradmin\nvim-v0.11.3\bin\nvim.exe
Task coverage deno coverage .coverage "--lcov"
error: Failed reading 'D:\a\deno-denops-test\deno-denops-test\.coverage\029bbb54-fcc6-42c0-8205-9a28961d8a65.json'
Caused by:
    EOF while parsing a value at line 1 column 0
Error: Process completed with exit code 1.

Hm...

Shougo · 2025-09-29T05:15:03Z

Error generating coverage report: Failed reading 'D:\a\deno-denops-test\deno-denops-test\.coverage\029bbb54-fcc6-42c0-8205-9a28961d8a65.json'

lambdalisue · 2025-10-05T05:52:54Z

🤔

lambdalisue · 2025-10-05T06:12:58Z

denoland/deno#30718

It seems the issue above is not only Deno v2.5.0...

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c5ac0df and d32061c.

📒 Files selected for processing (2)

.github/workflows/test.yml (4 hunks)
README.md (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

README.md

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: test (ubuntu-latest, 2.x, v9.1.1646, v0.11.3)
GitHub Check: test (macos-latest, ~2.3, v9.1.1646, v0.11.3)
GitHub Check: test (macos-latest, 2.x, v9.1.1646, v0.11.3)
GitHub Check: test (windows-latest, 2.x, v9.1.1646, v0.11.3)

.github/workflows/test.yml

lambdalisue · 2025-10-05T11:56:57Z

lovell/detect-libc#33 will fix the issue on Linux (but on Windows)

We now can use deno's built-in functionality to update dependencies.

lambdalisue · 2025-10-05T13:17:01Z

CI fails because of coverage generation (denoland/deno#30924) so merge.

📦 Upgrade Denops to v8

166de2e

lambdalisue added 2 commits September 29, 2025 02:52

☕ Follow Denops v8 requirements

faa979e

☕ Avoid no-import-prefix lint rule

6d21a44

lambdalisue force-pushed the v8 branch from 6d02359 to 6d21a44 Compare September 28, 2025 17:55

☕ Use ~2.3 instead of 2.3.0 for deno_version matrix

e769196

lambdalisue force-pushed the v8 branch from c5ac0df to d32061c Compare October 5, 2025 08:08

coderabbitai bot reviewed Oct 5, 2025

View reviewed changes

.github/workflows/test.yml Show resolved Hide resolved

lambdalisue force-pushed the v8 branch 2 times, most recently from 44120d0 to cafb0eb Compare October 5, 2025 08:37

lambdalisue force-pushed the v8 branch 2 times, most recently from 369814b to 083b23a Compare October 5, 2025 12:18

lambdalisue added 3 commits October 5, 2025 21:21

☕ Remove coverage related tasks and directly apply in CI

67995b7

☕ Remove update related tasks and CI

247b971

We now can use deno's built-in functionality to update dependencies.

☕ Force LF on Windows

23146b3

lambdalisue force-pushed the v8 branch from 083b23a to 23146b3 Compare October 5, 2025 12:21

lambdalisue merged commit 1ab90fe into main Oct 5, 2025
23 of 30 checks passed

lambdalisue deleted the v8 branch October 5, 2025 13:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

📦 Upgrade @denops/core to v8 #38

📦 Upgrade @denops/core to v8 #38

Uh oh!

lambdalisue commented Sep 28, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Sep 28, 2025 •

edited

Loading

Uh oh!

codecov bot commented Sep 28, 2025 •

edited

Loading

Uh oh!

Shougo commented Sep 29, 2025

Uh oh!

Shougo commented Sep 29, 2025

Uh oh!

lambdalisue commented Oct 5, 2025

Uh oh!

lambdalisue commented Oct 5, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

lambdalisue commented Oct 5, 2025

Uh oh!

lambdalisue commented Oct 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

📦 Upgrade @denops/core to v8 #38

📦 Upgrade @denops/core to v8 #38

Uh oh!

Conversation

lambdalisue commented Sep 28, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Purpose

📝 Description

What Changed

Implementation Approach

🔄 Type of Change

🧪 Testing

Test Coverage

Test Results

✅ Checklist

Code Quality

Documentation

Testing

Dependencies

🔗 Related Issues

🚀 Deployment Notes

📊 Performance Impact

📚 References

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Pre-merge checks and finishing touches

Uh oh!

codecov bot commented Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Shougo commented Sep 29, 2025

Uh oh!

Shougo commented Sep 29, 2025

Uh oh!

lambdalisue commented Oct 5, 2025

Uh oh!

lambdalisue commented Oct 5, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lambdalisue commented Oct 5, 2025

Uh oh!

lambdalisue commented Oct 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lambdalisue commented Sep 28, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 28, 2025 •

edited

Loading

codecov bot commented Sep 28, 2025 •

edited

Loading