Conversation
Update ADRs and metrics
There was a problem hiding this comment.
Pull request overview
This PR adds support for Mean Tweedie Deviance (MTD) as a new evaluation metric for point predictions. MTD is particularly well-suited for conflict forecasting data with zero-inflation and right-skewed distributions.
Changes:
- Added MTD metric calculation function with comprehensive documentation
- Registered MTD in the metrics registry and data model
- Added test coverage for the new metric with multiple power parameter values
- Updated README with a comprehensive metrics table documenting all available metrics
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| views_evaluation/evaluation/metrics.py | Added MTD field to PointEvaluationMetrics dataclass |
| views_evaluation/evaluation/metric_calculators.py | Implemented calculate_mtd function and registered it in POINT_METRIC_FUNCTIONS |
| tests/test_metric_calculators.py | Added tests for MTD calculation and updated expected metrics list |
| README.md | Fixed typo in section header and added comprehensive metrics comparison table |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
xiaolong0728
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.