Skip to content

Patch deprecated mergeOptions usage#227

Open
whns wants to merge 1 commit intovideojs:mainfrom
whns:main
Open

Patch deprecated mergeOptions usage#227
whns wants to merge 1 commit intovideojs:mainfrom
whns:main

Conversation

@whns
Copy link

@whns whns commented Oct 28, 2025

Description

The following videojs.mergeOptions call used when adding or resetting overlay items:

const mergeOptions = videojs.mergeOptions(this.options, o);
results in this deprecation warning being triggered on VideoJS 8.x:
VIDEOJS: WARN: videojs.mergeOptions is deprecated and will be removed in 9.0; please use videojs.obj.merge instead.

(For additional context on the deprecation, see https://videojs.org/guides/videojs-7-to-8/#newly-deprecated-functions.)

Specific Changes proposed

This changeset patches the relevant callsite with the existing approach used within reset.

Existing approach:

const merge = videojs.obj && videojs.obj.merge || videojs.mergeOptions;

Patch: 914d2c9

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Unit Tests updated or fixed
    • Docs/guides updated
  • Reviewed by Two Core Contributors

@whns
Copy link
Author

whns commented Oct 28, 2025

@wseymour15 Please let me know if there's any other details needed here or if this repo is no longer under active maintenance. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant