Open
Conversation
Author
|
@wseymour15 Please let me know if there's any other details needed here or if this repo is no longer under active maintenance. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The following
videojs.mergeOptionscall used when adding or resetting overlay items:videojs-overlay/src/plugin.js
Line 135 in f1fc449
VIDEOJS: WARN: videojs.mergeOptions is deprecated and will be removed in 9.0; please use videojs.obj.merge instead.(For additional context on the deprecation, see https://videojs.org/guides/videojs-7-to-8/#newly-deprecated-functions.)
Specific Changes proposed
This changeset patches the relevant callsite with the existing approach used within
reset.Existing approach:
videojs-overlay/src/plugin.js
Line 98 in f1fc449
Patch: 914d2c9
Requirements Checklist