use lazyAttrsOf and raw for nixosConfiguration #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR improves the Nix type system used in the Dendritic unflake configuration by replacing eager attribute evaluation with lazy evaluation patterns, fixing issue #1. The changes enhance performance and prevent potential infinite recursion issues with self-referencing module structures.
Key Changes:
- Updated type definitions to use
lazyAttrsOfandrawinstead ofattrsOfandanythingfor better lazy evaluation - Refactored the example NixOS configuration to use a more structured module pattern
- Improved README documentation with clearer descriptions and simplified command examples
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| modules/options/nixos-configurations.nix | Changed nixosConfigurations type from attrsOf anything to lazyAttrsOf raw for lazy evaluation |
| modules/options/modules.nix | Changed modules type to nested lazyAttrsOf for lazy evaluation; updated description wording |
| modules/example.nix | Refactored to define my-laptop module with imports, removed unused installer module, cleaned up whitespace |
| README.md | Improved documentation clarity and simplified command examples to use short-form flags |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
drupol
reviewed
Dec 10, 2025
|
|
||
| ```console | ||
| nixos-rebuild build --file . --attr nixosConfigurations.my-laptop | ||
| nixos-rebuild build -f . -A nixosConfigurations.my-laptop |
There was a problem hiding this comment.
nit: IMO, it was better with the expanded attribute, especially in a README file.
Owner
Author
There was a problem hiding this comment.
you are right, fixed in main :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1