fix(desktop): prevent terminal rerender when archiving task#60
Merged
Conversation
- Clean up all worktrees belonging to archived task, not just selected one - Use optimistic cache update to avoid workspace query refetch - Add clearActiveTerminalId to properly clean terminal state - Prevents unnecessary terminal disposal and recreation Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When archiving a task, other terminals were experiencing rendering issues due to unnecessary component rerenders and disposal.
Root Cause
openedWorktreeIds, leaving stale IDs for other worktrees of the archived taskinvalidateQueries(workspace.key())triggered a refetch, causingworktreesByRepositoryto update andopenedWorktreesarray to be recalculated, leading to TerminalPanel unmounting and remountingSolution
openedWorktreeIdsandactiveTerminalIdstateclearActiveTerminalIdmethod to terminal slice for proper state cleanupChanges
apps/desktop/src/renderer/src/App.tsx: UpdatedarchiveTaskMutationto clean up all archived task worktrees and use optimistic updateapps/desktop/src/renderer/src/stores/slices/terminal-slice.ts: AddedclearActiveTerminalIdmethodThis ensures terminal instances remain stable when archiving tasks, preventing the disposal and recreation that was causing rendering issues.