add --ban-sample option to haplotype sampling #4774
Merged
+25
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It would be a bit faster to convert the banned sample names into integer ids. Then you could use the |
Contributor
Author
|
Yeah, I don't think the small speed differential would be worth the more confusing code. If this ever becomes a bottleneck I'd reconsider. Think I can just merge this, then? |
Contributor
|
You can merge this. I'll check before the next release if the performance impact is noticeable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
vg haplotypes --ban-sampleDescription
Per Jouni's suggestion on a previous PR, this partially redos #4758 to add
--ban-sampleas an option which will prevent the sampler from selecting any haplotypes from a particular sample. Useful when you want to do a poor man's leave-one-out experiment without actually rebuilding the entire graph.