Skip to content

add authentication support for private repositories#32

Merged
lykhvar merged 2 commits intovet-run:feat/authfrom
ehthxC7x9D:main
Aug 20, 2025
Merged

add authentication support for private repositories#32
lykhvar merged 2 commits intovet-run:feat/authfrom
ehthxC7x9D:main

Conversation

@ehthxC7x9D
Copy link

@ehthxC7x9D ehthxC7x9D commented Aug 15, 2025

support for ~/.netrc
support for environment variable
support for stdin

notes:

I was not able to confirm that wget, independent of vet, could read my ~/.netrc file despite it being used successfully by curl. I was testing on wget 1.21.3 debian bookworm, so maybe someone else can verify that please.

re: issue #4

support for ~/.netrc
support for environment variable
support for stdin
@lykhvar
Copy link
Contributor

lykhvar commented Aug 17, 2025

@jarebear6expepjozn6rakjq5iczi3irqwphcvb, thank you for this contribution! My apologies for the delayed response; it’s been a busy few days. I’ll be reviewing it over the next couple of days and am excited to dig in.

@lykhvar
Copy link
Contributor

lykhvar commented Aug 20, 2025

Thanks again for this PR @jarebear6expepjozn6rakjq5iczi3irqwphcvb! Your work here was a huge help, as it made me realize the original specification for this feature needs to be extended.

Rather than merging directly, my plan is to retarget this PR to a new feature branch. From there, I’ll build on your work, introduce a custom HTTP header option, update the test cases, and then merge into main with you credited as co-author.

Thanks again for taking the time to contribute and get this feature started!

@lykhvar lykhvar changed the base branch from main to feat/auth August 20, 2025 12:06
@lykhvar lykhvar merged commit ad62364 into vet-run:feat/auth Aug 20, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants