Adding VoyageAI integration by fzowl · Pull Request #35273 · vespa-engine/vespa

fzowl · 2025-11-09T10:43:46Z

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

bjorncs

Thank you for your contribution, and for taking the time to improve Vespa!
Overall the changes look good and align well with our codebase.
Here are some initial feedback. We'll come back with more later.

vespa-dependencies-enforcer/allowed-maven-dependencies.txt

model-integration/pom.xml

model-integration/src/test/java/ai/vespa/embedding/VoyageAIEmbedderIntegrationTest.java

config-model/src/main/java/com/yahoo/vespa/model/container/component/VoyageAIEmbedder.java

model-integration/src/main/resources/examples/voyageai/article.sd

config-model/src/main/resources/schema/common.rnc

bjorncs · 2025-11-11T13:59:51Z

config-model/src/main/resources/schema/common.rnc

+   element model { xsd:string }? &
+   element api-key-secret-name { xsd:string } &
+   element endpoint { xsd:string }? &
+   element max-batch-size { xsd:positiveInteger }? &


The max batch size parameter is not used by the implementation. Remove?

Please also remove the max-batch-size definition here.

config-model/src/main/resources/schema/common.rnc

bjorncs · 2025-11-11T14:06:55Z

model-integration/src/main/resources/examples/voyageai/README.md

We want to move the user facing documentation to our documentation repository (https://github.com/vespa-engine/documentation, https://docs.vespa.ai/en/embedding.html). Please create a PR there after we have settled on the design.

For any implementation details just add them as (javadoc) comments to VoyageAIEmbedder.

@bjorncs Sure, i'll check the repo and raise a PR.

vespa-engine/documentation#4237

bjorncs · 2025-11-13T10:33:02Z

@fzowl Some unit tests are failing in the config-model module.

[ERROR] Failures:
[ERROR]   VoyageAIEmbedderTest.testVoyageAIEmbedderMissingApiKey:87 expected: <true> but was: <false>
[ERROR] Errors:
[ERROR]   VoyageAIEmbedderTest.testMultipleVoyageAIEmbedders:157->getVoyageAIEmbedderConfig:181 » IllegalArgument No enum constant com.yahoo.embedding.voyageai.VoyageAiEmbedderConfig.DefaultInputType.Enum.QUERY
[ERROR]   VoyageAIEmbedderTest.testVoyageAIEmbedderWithFullConfiguration:30->getVoyageAIEmbedderConfig:181 » IllegalArgument No enum constant com.yahoo.embedding.voyageai.VoyageAiEmbedderConfig.DefaultInputType.Enum.QUERY
[INFO]
[ERROR] Tests run: 1819, Failures: 1, Errors: 2, Skipped: 5

bjorncs

See comments

model-integration/src/main/java/ai/vespa/embedding/VoyageAIEmbedder.java

bjorncs · 2025-11-13T11:40:06Z

config-model/src/main/resources/schema/common.rnc

+   element model { xsd:string }? &
+   element api-key-secret-name { xsd:string } &
+   element endpoint { xsd:string }? &
+   element max-batch-size { xsd:positiveInteger }? &


Please also remove the max-batch-size definition here.

config-model/src/main/resources/schema/common.rnc

bjorncs · 2025-11-13T11:42:01Z

config-model/src/main/resources/schema/common.rnc

+   element normalize { xsd:boolean }? &
+   element truncate { xsd:boolean }? &
+   element pool-size { xsd:positiveInteger }? &
+   element cache-size { xsd:nonNegativeInteger }?


See my comment regarding caching.

bjorncs · 2025-11-13T11:48:08Z

model-integration/src/main/java/ai/vespa/embedding/VoyageAIEmbedder.java

+        return new OkHttpClient.Builder()
+                .connectTimeout(Duration.ofMillis(config.timeout()))
+                .readTimeout(Duration.ofMillis(config.timeout()))
+                .writeTimeout(Duration.ofMillis(config.timeout()))


Please specify the callTimeout as well for a proper request-response timeout on the client side.

We want to later include a timeout value in the Context, so timeout can be tied to the logical operation (respect overall feed/query time). For now we'll use the timeout configured in the embedder, but later will override the call timeout per request and use the lowest of those two.

model-integration/src/main/java/ai/vespa/embedding/VoyageAIEmbedder.java

fzowl · 2025-11-17T12:36:07Z

@bjorncs, can you please double-check the PR?

bjorncs

See comments. The PR build fails with a compilation error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project config-model: Compilation failure: Compilation failure:
--
  | [ERROR] /workspace/build/buildkite/vespaai/vespa-engine-vespa/config-model/src/main/java/com/yahoo/vespa/model/container/component/VoyageAIEmbedder.java:[167,20] cannot find symbol
  | [ERROR]   symbol:   method poolSize(java.lang.Integer)
  | [ERROR]   location: variable builder of type com.yahoo.embedding.voyageai.VoyageAiEmbedderConfig.Builder
  | [ERROR] /workspace/build/buildkite/vespaai/vespa-engine-vespa/config-model/src/main/java/com/yahoo/vespa/model/container/component/VoyageAIEmbedder.java:[170,20] cannot find symbol
  | [ERROR]   symbol:   method cacheSize(java.lang.Integer)
  | [ERROR]   location: variable builder of type com.yahoo.embedding.voyageai.VoyageAiEmbedderConfig.Builder

bjorncs · 2025-11-17T15:30:18Z

config-model/src/main/resources/schema/common.rnc


+VoyageAIEmbedder =
+   attribute type { "voyage-ai-embedder" } &
+   element model { xsd:string }? &


In your API the 'model' parameter is required. We should do the same here to avoid having the default model being defined by Vespa.

bjorncs · 2025-11-17T15:33:05Z

configdefinitions/src/vespa/voyage-ai-embedder.def

+endpoint                 string default="https://api.voyageai.com/v1/embeddings"
+
+# VoyageAI model name (e.g., voyage-3.5, voyage-3.5-lite, voyage-code-3, voyage-finance-2)
+model                    string default="voyage-3.5"


Please remove the default value (see my comment regarding <model>).

fzowl · 2025-11-17T18:28:44Z

@bjorncs Ah, sorry about these. I corrected the issues and updated the documentation PR as well. vespa-engine/documentation#4237

bjorncs · 2025-11-18T08:12:20Z

FYI some unit tests failed after making model mandatory

[ERROR] Failures:
[ERROR]   VoyageAIEmbedderTest.testVoyageAIEmbedderInvalidInputType:124 expected: <true> but was: <false>
[ERROR]   VoyageAIEmbedderTest.testVoyageAIEmbedderInvalidTimeout:105 expected: <true> but was: <false>
[ERROR] Errors:
[ERROR]   VoyageAIEmbedderTest.testMultipleVoyageAIEmbedders:148->loadModel:166 » IllegalArgument Invalid XML according to XML schema, error in services.xml: element "component" incomplete; missing required element "model" [25:21], input:
22:        <!-- VoyageAI Embedder with minimal configuration -->
23:        <component id="voyage-minimal" type="voyage-ai-embedder">
24:            <api-key-secret-ref>voyage_key</api-key-secret-ref>
25:        </component>
26:    </container>
27:</services>
[ERROR]   VoyageAIEmbedderTest.testVoyageAIEmbedderWithFullConfiguration:24->loadModel:166 » IllegalArgument Invalid XML according to XML schema, error in services.xml: element "component" incomplete; missing required element "model" [25:21], input:
22:        <!-- VoyageAI Embedder with minimal configuration -->
23:        <component id="voyage-minimal" type="voyage-ai-embedder">
24:            <api-key-secret-ref>voyage_key</api-key-secret-ref>
25:        </component>
26:    </container>
27:</services>
[ERROR]   VoyageAIEmbedderTest.testVoyageAIEmbedderWithMinimalConfiguration:48->loadModel:166 » IllegalArgument Invalid XML according to XML schema, error in services.xml: element "component" incomplete; missing required element "model" [25:21], input:
22:        <!-- VoyageAI Embedder with minimal configuration -->
23:        <component id="voyage-minimal" type="voyage-ai-embedder">
24:            <api-key-secret-ref>voyage_key</api-key-secret-ref>
25:        </component>
26:    </container>
27:</services>

fzowl · 2025-11-18T10:58:44Z

@bjorncs Should be fine now.

Adding VoyageAI integration

1b15925

bratseth requested a review from bjorncs November 10, 2025 11:46

bjorncs reviewed Nov 11, 2025

View reviewed changes

esolitos added the External Contribution label Nov 11, 2025

fzowl and others added 4 commits November 12, 2025 16:23

Merge branch 'vespa-engine:master' into voyageai_integration

aac02f2

Corrections due to comments

cc148cb

Corrections due to comments

05749de

Corrections due to comments

235f412

fzowl requested a review from bjorncs November 12, 2025 17:46

Corrections due to comments

a03b9b5

Corrections due to comments

af57f2c

bjorncs reviewed Nov 13, 2025

View reviewed changes

fzowl and others added 2 commits November 17, 2025 12:14

Merge branch 'vespa-engine:master' into voyageai_integration

b54c149

Corrections due to comments

f8d74a9

fzowl requested a review from bjorncs November 17, 2025 12:35

bjorncs reviewed Nov 17, 2025

View reviewed changes

Corrections due to comments

5a4251a

Corrections due to comments

dc44417

fzowl requested a review from bjorncs November 18, 2025 10:58

refactor: move generated config class to ai.vespa.embedding.config

fd7e3fe

bjorncs approved these changes Nov 20, 2025

View reviewed changes

bjorncs added DO NOT MERGE and removed DO NOT MERGE labels Nov 20, 2025

bjorncs merged commit a7552a0 into vespa-engine:master Nov 24, 2025
2 of 3 checks passed

Conversation

fzowl commented Nov 9, 2025

Uh oh!

bjorncs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fzowl Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bjorncs commented Nov 13, 2025

Uh oh!

bjorncs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fzowl commented Nov 17, 2025

Uh oh!

bjorncs left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fzowl commented Nov 17, 2025

Uh oh!

bjorncs commented Nov 18, 2025

Uh oh!

fzowl commented Nov 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fzowl Nov 12, 2025 •

edited

Loading