Improve client_os value in the session information #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, vertica-nodejs uses the os.platform()'s output as the client_os value in the session information. To set more helpful information like the value set by vsql, it needs to use os.type(), os.release(), and os.machine() to generate the value. However, os.machine() doesn't exist in Node.js 12 and 14. So I chose os.arch() to replace it only for both releases.
'mochatest/integration/client/vertica-connection-params-tests.js' has a test case to check the client_os value in the session information. I also modified this test case.
CI has been passed.