Bugfix - QueryProfilerInterface gave error when there was no queue time #1352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Should we add a test for the case where queue time or duration is Null? |
Collaborator
Author
As this is the UI part, we do not have tests for UI. We probably need a nig effort to incorporate the tests for UI. At that time we can incorporate such cases as well. But for now issues are being caught as people interact with the UI. |
lcoffinOT
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i have created helper functions to process the queue_time and run_time values for the QueryProfiler object.
For the QueryProfilerInterface, I have added checks for cases when the values could be None.
This will make the QueryProfilerInterface support older qprofs.