BugFix - QueryProfiler - Added handling for namespace #1346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mail4umar
added
Bug
afard
reviewed
Mar 17, 2025
| ) | ||
| if rel_transf.split('"')[2] != ".": | ||
| raise ParsingError("The format of the input relation is incorrect.") | ||
| elif quote_nb == 0 and dot_nb == 2: |
Collaborator
There was a problem hiding this comment.
Can you please add a unit test for this case?
Collaborator
Author
There was a problem hiding this comment.
We previously did not have any unit tests. I have added unit tests for all cases.
afard
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we never encountered namespace issue for QueryProfiler.
But it turns out that Eon mode has namespaces. The current function
schema_relationwhich is used inside theget_qplan_treewould give an error if a relation name like "name_space.schema.table" was provided. Now, I have added a handling for such a case.The function
schema_relationwould return below for the case of "name_space.schema.table":schema = 'name_space.table'
relation_name = 'table'