Update $lib.stix and fix skipped tests #4649
Open
+94
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## synapse-3xx #4649 +/- ##
===============================================
+ Coverage 96.68% 96.75% +0.07%
===============================================
Files 252 252
Lines 60709 60709
===============================================
+ Hits 58698 58742 +44
+ Misses 2011 1967 -44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Cisphyx
commented
Jan 6, 2026
|
|
||
| {'type': (None, 'uses', None), 'storm': 'yield $n1node [ +(used)> { yield $n2node } ]'}, | ||
| {'type': (None, 'indicates', None), 'storm': 'yield $n1node [ +(indicates)> { yield $n2node } ]'}, | ||
| {'type': (None, 'indicates', None), 'storm': 'yield $n1node [ +(refs)> { yield $n2node } ]'}, |
Contributor
Author
There was a problem hiding this comment.
Do we want to add an indicates edge from it:sec:stix:indicator to the model or use something else?
Cisphyx
commented
Jan 6, 2026
Comment on lines
+305
to
307
| # Should these just be the smallest .min and largest .max values that the tag has on any node? | ||
| # 'first_seen': '+:seen $seen=:seen return($lib.stix.export.timestamp($seen.0))', | ||
| # 'last_seen': '+:seen $seen=:seen return($lib.stix.export.timestamp($seen.1))', |
Contributor
Author
There was a problem hiding this comment.
Does this make sense? Or should this be something like -> risk:tool:software:tag :used.min/:used.max?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.