systemPropertyVariables configuration option#8
Open
msiedlarek wants to merge 1 commit intovert-x:masterfrom
msiedlarek:system-properties
Open
systemPropertyVariables configuration option#8msiedlarek wants to merge 1 commit intovert-x:masterfrom msiedlarek:system-properties
msiedlarek wants to merge 1 commit intovert-x:masterfrom
msiedlarek:system-properties
Conversation
Member
|
Have you signed the Eclipse CLA? Also, can you provide the email address you signed it with? |
Author
|
Well, I tried to... https://bugs.eclipse.org/bugs/show_bug.cgi?id=412009 . I'll let you know as soon as it's done. |
Member
|
Weird - I have no problem signing it, and lots of other people have without problem. Can you try a different browser? |
Author
|
Tried Safari 6.0.5, Chrome 27 and Firefox 21 with same result. |
Author
|
The CLA bug have been fixed and I've signed mine. You are free to merge my humble patch. |
|
Simple but useful feature, will it be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds a
systemPropertyVariablesconfiguration option, which allows you to define system properties to be set when running a module.This is particularly useful for setting the
org.vertx.logger-delegate-factory-class-nameproperty (my use case).The option name and concept comes from the Apache Maven Surefire plugin (https://maven.apache.org/surefire/maven-surefire-plugin/examples/system-properties.html).