Skip to content

Conversation

@paustin01
Copy link
Contributor

…cy controls

  • Add fail_on_api_error parameter (default: true) to control whether API connectivity/authentication errors block deployments
  • Remove fail_on_rejection parameter (redundant with server-side rule status)
  • Remove skip_preflight_checks parameter (replaced by server-side control per ADR-020)
  • Preflight rejections (409, 423, 428) now always fail - policy enforcement is controlled server-side via rule status (enabled, report_only, disabled)
  • API errors (401, 403, 404, 422, timeouts, connection errors) respect fail_on_api_error setting
  • Update documentation to explain server-side policy control approach
  • Add comprehensive test suite for new functionality

This change provides cleaner separation of concerns:

  • Client controls: API connectivity issues (fail_on_api_error)
  • Server controls: Policy enforcement (rule status field)
  • No client-side policy override possible

Related: versioner-dev-docs/tasks/fail-on-api-error-parameter.md

Description

Please include a summary of the changes and the related issue. Include relevant motivation and context.

Fixes # (issue)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test improvement

Changes Made

Testing

Please describe the tests you ran to verify your changes.

  • Unit tests pass (npm test)
  • Linting passes (npm run lint)
  • Build succeeds (npm run build)
  • Tested in a real GitHub workflow
  • Added new tests for new functionality

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have rebuilt and committed the dist/ directory
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Add screenshots to help explain your changes.

Additional Notes

Add any additional notes for reviewers here.

…cy controls

- Add fail_on_api_error parameter (default: true) to control whether API
  connectivity/authentication errors block deployments
- Remove fail_on_rejection parameter (redundant with server-side rule status)
- Remove skip_preflight_checks parameter (replaced by server-side control per ADR-020)
- Preflight rejections (409, 423, 428) now always fail - policy enforcement
  is controlled server-side via rule status (enabled, report_only, disabled)
- API errors (401, 403, 404, 422, timeouts, connection errors) respect
  fail_on_api_error setting
- Update documentation to explain server-side policy control approach
- Add comprehensive test suite for new functionality

This change provides cleaner separation of concerns:
- Client controls: API connectivity issues (fail_on_api_error)
- Server controls: Policy enforcement (rule status field)
- No client-side policy override possible

Related: versioner-dev-docs/tasks/fail-on-api-error-parameter.md
@paustin01 paustin01 merged commit b962f39 into main Dec 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants