fix: memo comparison functions return false instead of true#1329
Open
alessandroliva wants to merge 1 commit intovercel:mainfrom
Open
fix: memo comparison functions return false instead of true#1329alessandroliva wants to merge 1 commit intovercel:mainfrom
alessandroliva wants to merge 1 commit intovercel:mainfrom
Conversation
Contributor
|
@alessandroliva is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
MrAllgoodWilson
approved these changes
Dec 4, 2025
|
I approve |
MrAllgoodWilson
approved these changes
Dec 23, 2025
MrAllgoodWilson
approved these changes
Dec 23, 2025
MrAllgoodWilson
approved these changes
Dec 23, 2025
MrAllgoodWilson
approved these changes
Dec 23, 2025
MrAllgoodWilson
approved these changes
Dec 23, 2025
MrAllgoodWilson
approved these changes
Dec 23, 2025
MrAllgoodWilson
approved these changes
Dec 23, 2025
MrAllgoodWilson
approved these changes
Dec 23, 2025
MrAllgoodWilson
approved these changes
Dec 23, 2025
Author
|
@MrAllgoodWilson please stop spamming |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I propose a fix for
React.memocomparison functions inMessagesandPreviewMessagethat always returnefalse, effectively disabling memoization.Problem
Both components define a custom comparison function for
React.memo, but they end with an unconditionalreturn false.Because the final line is always
false, these components re-render on every parent update, regardless of whether the relevant props actually changed.Testing
Verified the app still updates when:
streaming→ready).Confirmed that, when props are unchanged, the components are now eligible to be skipped by
React.memo, reducing unnecessary re-renders in longer chats.