Fixing downloads from private repository #134
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bugii is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
rastiqdev
added a commit
to AnimeoTV/hazel
that referenced
this pull request
Jul 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #103 but more minimal and fixes an issue I encountered with anthrax63's solution.
The issue was that according to the GitHub docs (https://docs.github.com/en/rest/reference/repos#get-a-release-asset) there are 2 response types possible:
"To download the asset's binary content, set the
Acceptheader of the request toapplication/octet-stream. The API will either redirect the client to the location, or stream it directly if possible. API clients should handle both a200or302response."If you don't manually handle the 302 response, node-fetch automatically redirects and uses the same HTTP headers as the initial request. Github API then complains that both query params & HTTP header authentication mechanism is present and throws an error. For this reason, 302 redirects are handled manually.