Add uid/gid fields to FsStat and name resolution callbacks for ls/stat#150
Open
deathbyknowledge wants to merge 2 commits intovercel-labs:mainfrom
Open
Add uid/gid fields to FsStat and name resolution callbacks for ls/stat#150deathbyknowledge wants to merge 2 commits intovercel-labs:mainfrom
deathbyknowledge wants to merge 2 commits intovercel-labs:mainfrom
Conversation
|
@deathbyknowledge is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off, this is an awesome project!
I have a custom
IFileSystemimplementation that has its own file ownership. Currentlyls -lhardcodesuser userandstathardcodes1000/user, making the ownership invisible. I've tried fixing this in a backwards compatible way, happy to amend as necessary.uidandgidfields toFsStatinterfaceuidToName/gidToNamecallback options toBashOptionsfor resolving numeric IDs to namesls -lnow uses realstat.modeviaformatMode()instead of hardcodingdrwxr-xr-x/-rw-r--r--ls -lresolves owner/group names fromstat.uid/stat.gidusing callbacks (falls back to "user"/"group")stat -cformat specifiers%u,%U,%g,%Guse real stat values + name resolution