feat(core): add onError callback to createSpecStreamCompiler#217
Open
nil957 wants to merge 1 commit intovercel-labs:mainfrom
Open
feat(core): add onError callback to createSpecStreamCompiler#217nil957 wants to merge 1 commit intovercel-labs:mainfrom
nil957 wants to merge 1 commit intovercel-labs:mainfrom
Conversation
Adds optional `onError` callback to SpecStreamCompiler for debugging
malformed JSON patches during streaming.
Changes:
- New `SpecStreamCompilerOptions` interface with `initial` and `onError`
- Updated function signature (backward compatible via options object)
- Calls onError when:
- Line starts with { but fails to parse
- Patch application fails (e.g., test operation mismatch)
Example:
```typescript
const compiler = createSpecStreamCompiler({
onError: (line, error) => {
console.warn('Failed to parse:', line);
if (error) console.error(error);
},
});
```
This makes debugging easier in production when LLMs generate invalid patches.
Contributor
|
Someone is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds optional
onErrorcallback tocreateSpecStreamCompilerfor debugging malformed JSON patches during streaming.Problem
Currently, when
createSpecStreamCompilerencounters malformed JSON or patch application failures, it silently ignores them. This makes debugging difficult in production when LLMs generate invalid patches.Solution
New Options Interface
When onError is Called
{butparseSpecStreamLinereturnsnullapplySpecStreamPatchthrows (e.g.,testoperation mismatch)Example Usage
Backward Compatibility
Old signature still works:
New signature:
Use Cases
Checklist