fix(core): add truncation recovery to parseSpecStreamLine#213
Open
nil957 wants to merge 1 commit intovercel-labs:mainfrom
Open
fix(core): add truncation recovery to parseSpecStreamLine#213nil957 wants to merge 1 commit intovercel-labs:mainfrom
nil957 wants to merge 1 commit intovercel-labs:mainfrom
Conversation
Addresses vercel-labs#196 When LLM responses are truncated mid-stream, parseSpecStreamLine now attempts to repair the JSON by closing unclosed brackets, braces, and strings before giving up. This improves resilience during streaming scenarios where network issues or model interruptions cause incomplete JSON patches. Recovery handles: - Missing closing braces: {"op":"add"... -> adds } - Missing closing brackets: [1,2,3 -> adds ] - Unclosed strings: "value":"hello -> adds " - Nested structures: handles multiple levels Returns null for truly malformed JSON (mismatched brackets) to avoid false positives.
Contributor
|
Someone is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #196
When LLM responses are truncated mid-stream,
parseSpecStreamLinenow attempts to repair the JSON by closing unclosed brackets, braces, and strings before giving up.Problem
During streaming scenarios, network issues or model interruptions can cause incomplete JSON patches like:
{"op":"add","path":"/root","value":"main"Previously, these would silently fail with no recovery attempt.
Solution
Added
attemptJsonRepair()helper that:Recovery handles:
{"op":"add"...→ adds}[1,2,3→ adds]"value":"hello→ adds"Returns
nullfor truly malformed JSON (mismatched brackets) to avoid false positives.Testing
Added comprehensive test suite covering:
Checklist