Evidence::decode from Read + build and clippy fixes#38
Merged
thomas-fossati merged 2 commits intomainfrom May 7, 2025
Merged
Conversation
- Move imports that are only used by tests into the tests' modules. - Add missing #[cfg(test)] to tests modules. - allow(unexpected_cfgs) for modules that use bitmask! macro. This suppress a warning that originates from the bitmask crate. - Elide unused lifetime inside Visitor implementation. - Remove unused function. Signed-off-by: setrofim <setrofim@gmail.com>
setrofim
changed the title
Evidence::decode from Read + build and clippy fixes
Change Evidence::decode to accept a generic type that is Read. This allows for more flexibility in how this API is used, removing the need for additional conversions, and in some cases (e.g. when reading from a file), removing the need to created an intermediate buffer entirely. BREAKING_CHANGE: Signature of Evidence::decode is changed. Signed-off-by: setrofim <setrofim@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Evidence::decodeto accept a generic type that isRead. This allows for more flexibility in how this API is used, removing the need for additional conversions, and in some cases (e.g. when reading from a file), removing the need to created an intermediate buffer entirely.Also, various build and clippy fixes: