Skip to content

Feature/error on no server#48

Open
allevo wants to merge 2 commits intoveny:masterfrom
allevo:feature/error-on-no-server
Open

Feature/error on no server#48
allevo wants to merge 2 commits intoveny:masterfrom
allevo:feature/error-on-no-server

Conversation

@allevo
Copy link
Contributor

@allevo allevo commented May 27, 2016

If "_getJobServer" method doesn't return a valid JobServer, an error is emitted.
The event could be fired before any 'error' event listeners are attached.
This could crash the process.

Using nextTick, the developer is able to add an 'error' handler.

On connect method, the callback should be called only one time. The security guard is a good thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant