Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From boskworks@3d3b2b6
Explanation
Previously, we were calling
Map.removein an invokedynamic bootstrap method, because once the bootstrap was complete, the map entry was no longer needed.The problem is, under certain circumstances, the JVM is allowed to call the bootstrap method multiple times. Since we had removed the map entry, subsequent calls would fail.
It's not clear whether this caused any actual problems, or merely threw spurious exceptions. I didn't observe any test failures caused by this problem, but I thought we're better safe than sorry.
Risk
This change causes some more memory to be retained in the form of entries in the
CALL_SITES_BY_NAMEmap. The way Vena uses bosk, I'd guesstimate this will consume an extra few kilobytes.