Skip to content

Improve test coverage #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mano8 merged 25 commits into from
Jan 2, 2025
Merged

Improve test coverage #11

mano8 merged 25 commits into from
Jan 2, 2025

Conversation

@mano8
Copy link
Member

@mano8 mano8 commented Jan 2, 2025

Changes:

  • Improve code style
  • Correct bugs
  • Improve unit test coverage

mano8 added 25 commits January 1, 2025 21:18
@mano8
Add test methods test_read_file_io_error and test_validate_read
d36d047
@mano8
remove unnecessary import try bocks
3446b95
@mano8
Improve code style
3a38139
@mano8
improve code stlyle
9e40974
@mano8
Add TestFinaDfStats class
0603b57
@mano8
correct bug in get_dates_by_window
dc4190e
@mano8
improve test coverage
e224d3a
@mano8
Improve props validation in calculate_optimal_chunk_size method
8fa088b
@mano8
improve test coverage
a5112cc
@mano8
Add get_string_datetime_from_timestamp method and corresponding unit …
3cc9443 
…tests
@mano8
improve code style
564b0f8
@mano8
improve _validate_and_prepare_params props validation
ea10d99
@mano8
update max_size param value from 10_000 to 5_000_000 points in FinaSt…
63f1ac4 
…ats methods
@mano8
Improve FinaStats test coverage
47abbff
@mano8
rename module api_common to api_utils
b93dbf8
@mano8
apply changes on module api_utils name
0f4a2c3
@mano8
Improve code style
324594b
@mano8
Improve code style
a7f0a5a
@mano8
Add unit test class for api_utils module
e34fe2a
@mano8
remove async_get_uuid from EmonReader
28b591a
@mano8
improve test coverage
3920699
@mano8
Improve code style
dc97176
@mano8
inherit api_utils Utils from fina_utils Utils
53ef42d
@mano8
improve feed_id validation
8507fa0
@mano8
improve test coverage
86a2647
mano8
mano8 commented Jan 2, 2025
View reviewed changes
Copy link
Member Author

@mano8 mano8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@codecov
Copy link

codecov bot commented Jan 2, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.88889% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
emon_tools/emon_api.py 70.83% 2 Missing and 5 partials ⚠️
emon_tools/emon_fina.py 96.66% 1 Missing ⚠️
Files with missing lines Coverage Δ
emon_tools/api_utils.py 100.00% <100.00%> (ø)
emon_tools/fina_plot.py 93.82% <100.00%> (+4.17%) ⬆️
emon_tools/fina_time_series.py 100.00% <100.00%> (+21.15%) ⬆️
emon_tools/fina_utils.py 95.07% <100.00%> (+11.61%) ⬆️
emon_tools/emon_fina.py 95.49% <96.66%> (+17.82%) ⬆️
emon_tools/emon_api.py 81.08% <70.83%> (+9.74%) ⬆️

... and 1 file with indirect coverage changes

@mano8 mano8 linked an issue Jan 2, 2025 that may be closed by this pull request
Improve test coverage #9
Closed
@mano8 mano8 merged commit 303b4c6 into main Jan 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve test coverage

2 participants

@mano8