[bugfix] Excluding ImageTasks local creation with other regions and satellites#9
Open
velmer wants to merge 2 commits intoremote-sharingfrom
Open
[bugfix] Excluding ImageTasks local creation with other regions and satellites#9velmer wants to merge 2 commits intoremote-sharingfrom
velmer wants to merge 2 commits intoremote-sharingfrom
Conversation
…on, not only for date like it was before
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the bug?
When skipping ImageTasks local creation based on remotely processed ones, the SubmissionDispatcher is skipping a date regardless if there are or not remote ImageTasks, not only with same date, but with same region and satellite too (considering these 3 parameters as what makes the identification of an ImageTask).
What is the fix?
Instead of use a list of dates that have already been processed remotely, use a map that have a date as key and a list of remote ImageTasks processed in that date as value. Then, the SubmissionDispatcher tries to process every single date of submission date interval and only skips a local creation if there is a remote ImageTask with same date, region and satellite, not only with same date as was before.