Open
Conversation
…he processing of a ImageTask
…urce for processed ImageTasks and another resource for email
…ave had its ids specified
…gh header, now it's through query param)
# Conflicts: # src/main/java/org/fogbowcloud/saps/engine/scheduler/util/ProcessedImagesEmailBuilder.java
thiagomanel
requested changes
Jun 18, 2019
Collaborator
thiagomanel
left a comment
thiagomanel
left a comment
There was a problem hiding this comment.
seems ok to. I choose to mark as "Request changes" because this PR depends on #7 (I've made some request there)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR:
Request from a SAPS neighbor the access URL of a file generated by the processing of a ImageTask.
What problem will be solved:
Now a SAPS instance can send an email with the URLs of local and remote ImageTasks.
Modifications:
ProcessedImagesEmailBuilder.javaand its test class.Depends on PR(s): #7