Skip to content

Vf 329 koble opp en application til det semesteret den ble soekt pa#45

Merged
solvhold merged 5 commits intomainfrom
vf-329-koble-opp-en-application-til-det-semesteret-den-ble-soekt-pa
Nov 10, 2025
Merged

Vf 329 koble opp en application til det semesteret den ble soekt pa#45
solvhold merged 5 commits intomainfrom
vf-329-koble-opp-en-application-til-det-semesteret-den-ble-soekt-pa

Conversation

@solvhold
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Oct 20, 2025

@solvhold solvhold requested a review from kyrkjedelen October 20, 2025 15:24
Copy link
Collaborator

@kyrkjedelen kyrkjedelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarCloud mener dette også :)

@@ -37,6 +37,7 @@ export const selectTeamApplications = async (
motivationText: teamApplicationsTable.motivationText,
biography: teamApplicationsTable.biography,
teamInterest: teamApplicationsTable.teamInterest,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dette objektet ligner veldig på det under. Kan du dra det ut og resirkulere kode?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will make another issue for this

Copy link
Collaborator

@kyrkjedelen kyrkjedelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good now

@@ -37,6 +37,7 @@ export const selectTeamApplications = async (
motivationText: teamApplicationsTable.motivationText,
biography: teamApplicationsTable.biography,
teamInterest: teamApplicationsTable.teamInterest,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will make another issue for this

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
9.5% Duplication on New Code (required ≤ 4%)

See analysis details on SonarQube Cloud

@solvhold solvhold merged commit da85d99 into main Nov 10, 2025
7 of 8 checks passed
@TobiasH05 TobiasH05 deleted the vf-329-koble-opp-en-application-til-det-semesteret-den-ble-soekt-pa branch November 10, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants