Skip to content

feat: move selectTeamApplication from teams to applications #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
solvhold merged 3 commits into from
Sep 10, 2025
Merged

feat: move selectTeamApplication from teams to applications #38

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6ec644
feat: move selectTeamApplication from teams to applications
Sep 10, 2025
22e9af5
Merge branch 'main' into vf-298-move-selectteamapplicationsfromteams
solvhold Sep 10, 2025
d567f3e
fix: run pnpm check
Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 0 additions & 46 deletions src/routers/teams.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { selectTeamApplicationsByTeamId } from "@/src/db-access/applications";
import { selectTeamsById } from "@/src/db-access/teams";
import { clientError } from "@/src/error/http-errors";
import {
Expand All @@ -10,51 +9,6 @@ import { Router, json } from "express";
export const teamsRouter = Router();
teamsRouter.use(json());

/**
* @openapi
* /teams/{teamId}/applications/:
* get:
* tags: [teams]
* summary: Get teamapplication with teamid
* description: Get teamapplication with teamid
* parameters:
* - $ref: "#/components/parameters/offset"
* - $ref: "#/components/parameters/limit"
* responses:
* 200:
* description: Successfull response
* content:
* application/json:
* schema:
* $ref: "#/components/schemas/teamApplication"
*/
teamsRouter.get("/:teamId/applications/", async (req, res, next) => {
const teamIdResult = toSerialIdParser.safeParse(req.params.teamId);
if (!teamIdResult.success) {
return next(clientError(400, "Invalid request format", teamIdResult.error));
}
const queryParametersResult = listQueryParser.safeParse(req.query);
if (!queryParametersResult.success) {
return next(
clientError(400, "Invalid request format", queryParametersResult.error),
);
}
const databaseResult = await selectTeamApplicationsByTeamId(
[teamIdResult.data],
queryParametersResult.data,
);
if (!databaseResult.success) {
return next(
clientError(
400,
"Failed to execute the database command",
databaseResult.error,
),
);
}
res.json(databaseResult.data);
});

/**
* @openapi
* /teams/{teamId}/:
Expand Down