Skip to content

Conversation

@Milkysunshine
Copy link

Fix for 2025.5 breaking changes

Fix for 2025.5 breaking changes
Copy link

@Rumlik Rumlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working! Thanks!

@CWSpear
Copy link

CWSpear commented May 15, 2025

GitHub doesn't seem to want to let me comment on lines that aren't near the changes, but there's a bunch more hass.components.cloud calls that will cause errors if they are hit.

e.g.: Line R233

@Milkysunshine
Copy link
Author

GitHub doesn't seem to want to let me comment on lines that aren't near the changes, but there's a bunch more hass.components.cloud calls that will cause errors if they are hit.

e.g.: Line R233

Yes, @breiviar made the modifications to the full file, and posted the changes at https://github.com/breiviar/brama/blob/master/smartapp.py as discussed here: #133 (comment) .

I have made the adjustments as per their modifications to the rest of the file.

They should now show up in the PR.

@CWSpear
Copy link

CWSpear commented May 15, 2025

Unfortunately, it's still missing a few! This call is incorrect and will throw an error if we get there. All the new cloud.whatever methods need hass as the first param. https://github.com/breiviar/brama/blob/master/smartapp.py#L236

@Milkysunshine
Copy link
Author

Unfortunately, it's still missing a few! This call is incorrect and will throw an error if we get there. All the new cloud.whatever methods need hass as the first param. https://github.com/breiviar/brama/blob/master/smartapp.py#L236

Now I see what you meant.

I believe I have made all of the changes.

I made the changes to my file and reloaded HA. No errors, and everything is working as expected on my specific installation.

@CWSpear
Copy link

CWSpear commented May 15, 2025

Yeah, the line I pointed to has to do with created a webhook, which is only needed if you don't have a cloud URL (e.g. you manage your own reverse proxy).

The source code helps show the API for the calls: https://github.com/home-assistant/core/blob/dev/homeassistant/components/cloud/__init__.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants