-
-
Notifications
You must be signed in to change notification settings - Fork 59
Update smartapp.py #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update smartapp.py #134
Conversation
Fix for 2025.5 breaking changes
Rumlik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working! Thanks!
|
GitHub doesn't seem to want to let me comment on lines that aren't near the changes, but there's a bunch more e.g.: Line R233 |
Yes, @breiviar made the modifications to the full file, and posted the changes at https://github.com/breiviar/brama/blob/master/smartapp.py as discussed here: #133 (comment) . I have made the adjustments as per their modifications to the rest of the file. They should now show up in the PR. |
|
Unfortunately, it's still missing a few! This call is incorrect and will throw an error if we get there. All the new |
Now I see what you meant. I believe I have made all of the changes. I made the changes to my file and reloaded HA. No errors, and everything is working as expected on my specific installation. |
|
Yeah, the line I pointed to has to do with created a webhook, which is only needed if you don't have a cloud URL (e.g. you manage your own reverse proxy). The source code helps show the API for the calls: https://github.com/home-assistant/core/blob/dev/homeassistant/components/cloud/__init__.py |
Fix for 2025.5 breaking changes