Conversation
…step - Add explicit DNS (1.1.1.1, 1.0.0.1) to x-minion-base anchor - Minions were failing pip installs due to DNS resolution issues in CI - Remove frontend network creation step (not used without macvlan overlay) Contributions by: June
prepare-commit-msg prepends '# branch: name' hint, which broke validation when using 'git commit -m'. Now we skip # lines to find the actual subject line. Contributions by: June
…#14) ## Summary - Flip pip index order: pypi.org primary, Chinese mirrors as extras - Extras are checked in parallel so we still get speed benefits - More reliable for CI and general use since pypi.org is the source of truth Contributions by: June
## Summary - Fix commit-msg hook to skip comment lines (starting with #) when finding the subject line - Resolves issue where prepare-commit-msg's '# branch: name' hint broke validation when using 'git commit -m' ## Test plan - [ ] Run `git commit -m "test: message"` and verify hook validates correctly - [ ] Run `git commit` (editor mode) and verify hint comment is skipped
…step (#15) ## Summary - Add explicit DNS configuration (1.1.1.1, 1.0.0.1) to the x-minion-base anchor in docker-compose.yaml - Minions were failing pip installs during CI due to DNS resolution issues inside containers - Remove the frontend network creation step from test-states.yml (not used without macvlan overlay) ## Test plan - [ ] Verify CI workflow passes with the DNS configuration - [ ] Confirm pip installs work correctly in minion containers - [ ] Check that removing the frontend network step does not break any tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.