Fix tn93_args parameter handling in true_append#115
Closed
stevenweaver wants to merge 1 commit intomasterfrom
Closed
Fix tn93_args parameter handling in true_append#115stevenweaver wants to merge 1 commit intomasterfrom
stevenweaver wants to merge 1 commit intomasterfrom
Conversation
The tn93_args parameter in the run_tn93 function was not handling both string and list inputs correctly. When called from hivtrace.py, the parameter is passed as a list of arguments, but the previous implementation tried to iterate over the parameter and call .strip() on each element, which would fail for lists. This fix adds type checking to handle both interfaces: - String input (from CLI): splits on whitespace to create argument list - List input (from hivtrace.py): converts all elements to strings This resolves issues when true_append is executed as part of a pipeline from hivtrace.py, ensuring tn93 arguments are properly constructed for subprocess calls.
Member
Author
|
Closing - this was addressing the wrong issue. Need to work on cawlign migration instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The
run_tn93function intrue_append.pywas not properly handling thetn93_argsparameter when called programmatically fromhivtrace.py. The previous implementation attempted to iterate overtn93_argsand call.strip()on each element, which would fail when the parameter was passed as a list fromhivtrace.py:544-547.Solution
Added type checking to handle both interfaces:
hivtrace.py): Converts all elements to stringsThis ensures the subprocess command is built correctly regardless of how
true_appendis invoked.Test plan
This fix resolves pipeline execution issues where tn93 arguments were not being properly passed when true_append was called as part of the hivtrace pipeline.