Skip to content

Fix tn93_args parameter handling in true_append#115

Closed
stevenweaver wants to merge 1 commit intomasterfrom
fix-true-append-args-handling
Closed

Fix tn93_args parameter handling in true_append#115
stevenweaver wants to merge 1 commit intomasterfrom
fix-true-append-args-handling

Conversation

@stevenweaver
Copy link
Member

Summary

  • Fixed tn93_args parameter handling to support both string and list inputs
  • Ensures true_append works correctly when called from both CLI and hivtrace.py

Problem

The run_tn93 function in true_append.py was not properly handling the tn93_args parameter when called programmatically from hivtrace.py. The previous implementation attempted to iterate over tn93_args and call .strip() on each element, which would fail when the parameter was passed as a list from hivtrace.py:544-547.

Solution

Added type checking to handle both interfaces:

  • String input (from CLI): Splits on whitespace to create an argument list
  • List input (from hivtrace.py): Converts all elements to strings

This ensures the subprocess command is built correctly regardless of how true_append is invoked.

Test plan

  • Verified command building logic with both string and list inputs
  • Confirmed existing test suite passes
  • Tested that the fix handles edge cases (empty strings, mixed types in lists)

This fix resolves pipeline execution issues where tn93 arguments were not being properly passed when true_append was called as part of the hivtrace pipeline.

The tn93_args parameter in the run_tn93 function was not handling both
string and list inputs correctly. When called from hivtrace.py, the
parameter is passed as a list of arguments, but the previous
implementation tried to iterate over the parameter and call .strip()
on each element, which would fail for lists.

This fix adds type checking to handle both interfaces:
- String input (from CLI): splits on whitespace to create argument list
- List input (from hivtrace.py): converts all elements to strings

This resolves issues when true_append is executed as part of a pipeline
from hivtrace.py, ensuring tn93 arguments are properly constructed for
subprocess calls.
@stevenweaver
Copy link
Member Author

Closing - this was addressing the wrong issue. Need to work on cawlign migration instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant