fix(parser): handle multiple '!' characters in host patterns correctly (#46)#50
Merged
fix(parser): handle multiple '!' characters in host patterns correctly (#46)#50
Conversation
#46) Only the leading '!' character indicates a negated pattern. Any subsequent '!' characters are now treated as literal characters in the pattern. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
✔️ 86aef70 - Conventional commits check succeeded. |
Pull Request Test Coverage Report for Build 21547287276Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
!characters in host patterns!character is now treated as a negation marker!characters are treated as literal characters in the patternFixes #46
Changes
split('!')withstrip_prefix('!')inparse_host()functionhost!name,!host!name,!a!b!c,a!b)Test plan
should_parse_host_with_exclamation_in_patterncovers all edge cases🤖 Generated with Claude Code