Skip to content

Comments

fix(parser): handle escape sequences in quoted arguments (#44)#49

Merged
veeso merged 1 commit intomainfrom
fix/issue-44-escape-sequences
Jan 31, 2026
Merged

fix(parser): handle escape sequences in quoted arguments (#44)#49
veeso merged 1 commit intomainfrom
fix/issue-44-escape-sequences

Conversation

@veeso
Copy link
Owner

@veeso veeso commented Jan 31, 2026

Summary

  • Fixes Parser does not handle escape sequences in quoted arguments #44: Parser now handles escape sequences within quoted arguments
  • Added support for \" (escaped double quote), \\ (escaped backslash), and \' (escaped single quote)
  • Unrecognized escape sequences preserve the backslash, matching OpenSSH's argv_split() behavior

Test plan

  • Added should_unescape_quoted_args test for integration testing
  • Added should_count_unescaped_quotes unit test
  • Added should_detect_ends_with_unescaped_quote unit test
  • Added should_unescape_string unit test
  • All 151 tests pass
  • Clippy passes with no warnings
  • Format check passes

🤖 Generated with Claude Code

Added support for escape sequences within quoted strings:
- \" -> " (escaped double quote)
- \\ -> \ (escaped backslash)
- \' -> ' (escaped single quote)

Unrecognized escape sequences preserve the backslash, matching
OpenSSH's argv_split() behavior.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@cocogitto-bot
Copy link

cocogitto-bot bot commented Jan 31, 2026

✔️ 14989fd - Conventional commits check succeeded.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 21547222198

Details

  • 115 of 115 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 98.339%

Totals Coverage Status
Change from base Build 21547132309: 0.06%
Covered Lines: 3375
Relevant Lines: 3432

💛 - Coveralls

@veeso veeso merged commit 5cf42b2 into main Jan 31, 2026
6 checks passed
@veeso veeso deleted the fix/issue-44-escape-sequences branch January 31, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parser does not handle escape sequences in quoted arguments

2 participants