fix(parser): return error for mismatched quotes (#45)#48
Merged
Conversation
The parser now validates quotes in arguments and returns an InvalidQuotes error when they are mismatched, matching OpenSSH behavior. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Pull Request Test Coverage Report for Build 21547114344Details
💛 - Coveralls |
Breaking change: added InvalidQuotes variant to SshParserError enum. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
✔️ 374ff63...e0e305c - Conventional commits check succeeded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InvalidQuoteserror variant toSshParserErrorFixes #45
Test plan
should_fail_on_mismatched_quotesthat verifies:Hostname "example.comHostname example.com"Hostname foo "bar🤖 Generated with Claude Code