Skip to content

Conversation

@MaskyS
Copy link
Contributor

@MaskyS MaskyS commented Nov 16, 2019

I've made the changes suggested in https://www.drupal.org/project/projectapplications/issues/3036543 except for:

getIpAddressOriginCountry(): Do not use cURL directly, use Drupal HTTP client API (Guzzle). That way global proxy settings and other configuration for outgoing HTTP requests are respected.

getIpAddressOriginCountry(): this will generate PHP warnings if the response is not valid JSON and you will then return a null country. Error handling is missing here.

Please test before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant