Conversation
veech
left a comment
veech
left a comment
There was a problem hiding this comment.
Sorry it took so long to get to this. I had no idea there was an open pull request.
I actually ended up converting my project over to Python specifically because I didn't want to implement the Jpeg2000 encoding so this is great!
Regarding tests, I'm definitely open to adding tests to the library. I just haven't had a chance to come back to this in a while.
| * @param lat Latitude | ||
| * @param lon Longitude | ||
| */ | ||
| const lookupDataPoint = (packet: GRIBPacket, lat: number, lon: number): number | null => { |
There was a problem hiding this comment.
Could you explain a bit what this function would be used for?
There was a problem hiding this comment.
My intent was to have a way to get data associated with certain lat, lon from the packet. I wasn't able to find anything for this that's currently in the library.
What's your view on this?
There was a problem hiding this comment.
I think it's definitely something that is needed, however, it looks like this would only be compatible with GRIBs that utilize Grid Def Template 3.0.
For compatibility, I feel like this function should first check that the packet utilizes a compatible Grid Template.
2 participants
Apologies for the sheer amount of changes, if you think it's too overwhelming I'm going to split it up into several smaller self-contained PRs.
What is your take on tests, it feels like complexity is raising, should I add some for the relevant changes?