Skip to content

Mobile.qml: don't show BMS tab if BMS Type == None #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
surfdado wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −1
Open

Mobile.qml: don't show BMS tab if BMS Type == None #440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion mobile/main.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,8 @@ ApplicationWindow {

Page {
id: bmsPage
visible: false

Loader {
anchors.fill: parent
asynchronous: true
Expand Down Expand Up @@ -513,7 +515,7 @@ ApplicationWindow {

Repeater {
id: rep
model: ["Start", "RT Data", "BMS", "Profiles", "Terminal"]
model: ["Start", "RT Data", "Profiles", "Terminal"]

TabButton {
text: modelData
Expand Down Expand Up @@ -562,6 +564,13 @@ ApplicationWindow {
}
}

TabButton {
id: bmsDataButton
visible: bmsPage.visible
text: "BMS"
width: tabBar.buttonWidth
}

TabButton {
id: confMotorButton
visible: confPageMotor.visible
Expand Down Expand Up @@ -1146,6 +1155,8 @@ ApplicationWindow {

function onUpdated() {
confTimer.mcConfRx = true
/* BMS button is visible if BMS Type != None, or if it's not an ESC */
bmsDataButton.visible = (mMcConf.getParamInt("bms.type") > 0) || (VescIf.getFwSupportsConfiguration() == false)
}
}

Expand Down