Skip to content

Parse authentication credentials from Redis URI #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jay-l-e-e merged 1 commit into from
May 18, 2025
Merged

Parse authentication credentials from Redis URI #7

jay-l-e-e merged 1 commit into from
May 18, 2025

Conversation

@swaptr
Copy link
Contributor

@swaptr swaptr commented May 17, 2025

#6

What is changed?

This pull request addresses the issue where the Redis client does not extract authentication credentials from the provided URI.

Example

redis://user:secret@localhost:6379

The client will now correctly use user as the username and secret as the password for authentication.

@jay-l-e-e jay-l-e-e self-requested a review May 18, 2025 04:32
jay-l-e-e
jay-l-e-e approved these changes May 18, 2025
View reviewed changes
Copy link
Contributor

@jay-l-e-e jay-l-e-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jay-l-e-e jay-l-e-e merged commit d521f1e into vcms-io:main May 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jay-l-e-e jay-l-e-e jay-l-e-e approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@swaptr @jay-l-e-e