Allow all players to see "waiting for votes" message#722
Open
bjb568 wants to merge 1 commit intovck3000:masterfrom
Open
Allow all players to see "waiting for votes" message#722bjb568 wants to merge 1 commit intovck3000:masterfrom
bjb568 wants to merge 1 commit intovck3000:masterfrom
Conversation
bjb568
commented
Dec 8, 2024
Comment on lines
-166
to
-172
| // If user has voted already | ||
| if ( | ||
| indexOfPlayer !== undefined && | ||
| this.thisRoom.playersYetToVote.indexOf( | ||
| this.thisRoom.playersInGame[indexOfPlayer].username, | ||
| ) === -1 | ||
| ) { |
Contributor
Author
There was a problem hiding this comment.
Note that the "If user has voted already" branch was identical to the "If we are spectator" branch so the entire function can be replaced with the contents of either branch.
Owner
|
I'm keen to revisit this. Could you resolve the conflict and give it a test if you're able to please? Thanks :) |
Contributor
Author
|
@vck3000 It should be good now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code has not been tested, but the change is simple, it just removes the if statement.