Open
Conversation
combinations with 0
recursive solution
vck3000
reviewed
Jul 7, 2024
vck3000
reviewed
Jul 7, 2024
vck3000
reviewed
Jul 7, 2024
vck3000
reviewed
Jul 7, 2024
vck3000
reviewed
Jul 7, 2024
vck3000
reviewed
Jul 7, 2024
vck3000
reviewed
Jul 7, 2024
src/metrics/gameMetrics.ts
Outdated
| help: 'Total number of games played.', | ||
| labelOptions: { | ||
| status: new Set(['finished', 'voided']), | ||
| game_type: new Set(['custom', 'matchmaking', 'private']), |
Owner
There was a problem hiding this comment.
Let's call it something other than game_type. It can be easily confused with avalon / hunter or fab 4 or anything else.
How's something like "room_creation_type"?
On second thought, private games should probably be a separate metric.
Match made games vs custom games.
Within custom games, there's public and private. Idk on second thought if we should be mixing these into the same label.
Collaborator
Author
There was a problem hiding this comment.
from previous discussions have done a room_type which is matchmaking, public and private.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate metric by game type: custom, matchmaking, private